From a87812f436e08b14a7cede83e30306d779774872 Mon Sep 17 00:00:00 2001 From: Selene ToyKeeper Date: Mon, 25 Mar 2024 04:25:43 -0600 Subject: dammit, got alkaline detection half working and then my flashing adapter died (saving progress here so I can work on a different branch) --- fsm/ramping.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'fsm/ramping.h') diff --git a/fsm/ramping.h b/fsm/ramping.h index c4b7d48..6fe87fe 100644 --- a/fsm/ramping.h +++ b/fsm/ramping.h @@ -10,6 +10,9 @@ uint8_t actual_level = 0; // the level used before actual uint8_t prev_level = 0; +#ifdef USE_RAMP_LEVEL_HARD_LIMIT +uint8_t ramp_level_hard_limit = RAMP_SIZE; +#endif void set_level(uint8_t level); //void set_level_smooth(uint8_t level); -- cgit v1.2.3 From 35b5c42f8996167248b7e6d2e4053f6bbef1505c Mon Sep 17 00:00:00 2001 From: Selene ToyKeeper Date: Tue, 26 Mar 2024 03:41:17 -0600 Subject: d3aa: got weak battery detection actually working, and not letting the magic smoke out of updi adapters any more (probably) The alkaline detection might be a little too lenient though; it could potentially fail to activate limits when the cell is completely full or stronger than an average alkaline. One of my test cells measured at 72 / 75, so if it was just a little stronger it'd pass... but most alkalines I tried were in the 40 to 60 range and failed easily. OTOH, if I make it easier to fail, it's likely to trip on normal li-ion cells, and I don't want that. So as a future enhancement idea, maybe it should have a smaller sag threshold for AA and a larger threshold for li-ion. That would reduce false negatives for AA, while still preventing false positives for li-ion. --- fsm/ramping.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fsm/ramping.h') diff --git a/fsm/ramping.h b/fsm/ramping.h index 6fe87fe..f542bd2 100644 --- a/fsm/ramping.h +++ b/fsm/ramping.h @@ -11,7 +11,7 @@ uint8_t actual_level = 0; // the level used before actual uint8_t prev_level = 0; #ifdef USE_RAMP_LEVEL_HARD_LIMIT -uint8_t ramp_level_hard_limit = RAMP_SIZE; +uint8_t ramp_level_hard_limit = 0; #endif void set_level(uint8_t level); -- cgit v1.2.3