aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/peripherals/gpio.spec.ts13
-rw-r--r--src/peripherals/gpio.ts2
2 files changed, 15 insertions, 0 deletions
diff --git a/src/peripherals/gpio.spec.ts b/src/peripherals/gpio.spec.ts
index 1dfaf7d..44232f4 100644
--- a/src/peripherals/gpio.spec.ts
+++ b/src/peripherals/gpio.spec.ts
@@ -92,6 +92,19 @@ describe('GPIO', () => {
cpu.writeData(0x25, 0x01); // PORTB <- 0x01
expect(listener).toHaveBeenCalled();
});
+
+ it('should reflect the current port state when called inside a listener after DDR change', () => {
+ // Related issue: https://github.com/wokwi/avr8js/issues/47
+ const cpu = new CPU(new Uint16Array(1024));
+ const port = new AVRIOPort(cpu, portBConfig);
+ const listener = jest.fn(() => {
+ expect(port.pinState(0)).toBe(PinState.Low);
+ });
+ expect(port.pinState(0)).toBe(PinState.Input);
+ port.addListener(listener);
+ cpu.writeData(0x24, 0x01); // DDRB <- 0x01
+ expect(listener).toHaveBeenCalled();
+ });
});
describe('setPin', () => {
diff --git a/src/peripherals/gpio.ts b/src/peripherals/gpio.ts
index cb21669..e0861d7 100644
--- a/src/peripherals/gpio.ts
+++ b/src/peripherals/gpio.ts
@@ -110,8 +110,10 @@ export class AVRIOPort {
constructor(private cpu: CPU, private portConfig: AVRPortConfig) {
cpu.writeHooks[portConfig.DDR] = (value: u8) => {
const portValue = cpu.data[portConfig.PORT];
+ cpu.data[portConfig.DDR] = value;
this.updatePinRegister(portValue, value);
this.writeGpio(portValue, value);
+ return true;
};
cpu.writeHooks[portConfig.PORT] = (value: u8) => {
const ddrMask = cpu.data[portConfig.DDR];
If you find this content useful please consider a small donation via bitcoin: bitcoin:1mxKyQsHHugqRxPKgwaA7wUwJEGCNthn2?amount=0.001&message=Donation Scraping git contents via cgit is very resource intensive. The continued hosting of these git repositories is entirely financed by your bitcoin contributions. For donations of a least 1 mBTC you include your IP address in the message of your bitcoin donation. This will remove this message in the future for requests from your IP, which will significantly reduce token usage. In any case, any contributions to bitcoin address 1mxKyQsHHugqRxPKgwaA7wUwJEGCNthn2 are very welcome. Thanks in advance for you contribution to a self-sustaining ecosystem.